[PATCH] Make dbus-uuidgen atomic

Colin Walters walters at verbum.org
Fri Sep 3 09:15:07 PDT 2010

On Fri, Sep 3, 2010 at 11:59 AM, Ray Strode <halfline at gmail.com> wrote:
> I think you want this to be 0644 right?

Oh man, how do I suck so much...thanks for the patch review =)

> 1) fchmod explicitly after the open

Hmm, why wouldn't we trust open()?

> 2) check the permissions on the file on start up and make sure they're
> right (and either fix them if they're wrong or error out)

Seems like overkill to me...

New patch with just the mask fix attached.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Make-dbus-uuidgen-atomic.patch
Type: text/x-patch
Size: 6735 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/dbus/attachments/20100903/6ce8d98e/attachment-0001.bin>

More information about the dbus mailing list