[PATCH] Make dbus-uuidgen atomic

Colin Walters walters at verbum.org
Thu Sep 9 09:21:12 PDT 2010


On Fri, Sep 3, 2010 at 10:32 PM, Ray Strode <halfline at gmail.com> wrote:
>
> Well, there's a window between the open and the fchmod(), if you get a
> crash there and umask is hosed, that'd cause problems.

In practice though, you'd have to have booted the OS to be able to log
in to an admin shell and set your umask, and if you're that far the
init script will have already generated the UUID.

> Also, the admin could accidentally run chmod after machine-id is
> generated and be confused next boot when the system doesn't work.

Well, yeah, but there are infinite values of "admin could X"...we have
to do some filtering by probability and implementation time.


More information about the dbus mailing list