[PATCH 1/5] activation: change SystemdService to ActivationRequest
mzqohf at 0pointer.de
Mon Jan 3 14:05:05 PST 2011
On Mon, 03.01.11 21:45, Scott James Remnant (scott at netsplit.com) wrote:
> On Mon, Jan 3, 2011 at 8:35 PM, Lennart Poettering <mzqohf at 0pointer.de> wrote:
> > On Sun, 02.01.11 22:46, Scott James Remnant (scott at netsplit.com) wrote:
> >> - /* systemd service is never required */
> >> + /* activation request is never required */
> >> if (!bus_desktop_file_get_string (desktop_file,
> >> DBUS_SERVICE_SECTION,
> >> - DBUS_SERVICE_SYSTEMD_SERVICE,
> >> - &systemd_service, &tmp_error))
> >> + DBUS_SERVICE_ACTIVATION_REQUEST,
> >> + &activation_request, &tmp_error))
> > We need compat here. the old name must be checked too. Quite a few
> > projects already ship with prepared bus service files upstream.
> I just knocked up these patches for comments - it's of course entirely
> up to you how you'll want to manage the transition, since the signal
> is different as well and you might want to deal with older D-Bus and
> newer systemd and older systemd with newer D-Bus, etc.
Well, i can live with breaking compat between dbus and systemd, but not
between the apps and dbus/systemd. since the dbus service file syntax
is part of the interface between apps and dbus/systemd we need the compat.
Lennart Poettering - Red Hat, Inc.
More information about the dbus