Changing dbus/dbus-glib review procedure
Pavel Strashkin
pavel.strashkin at gmail.com
Tue May 17 16:36:33 PDT 2011
Hi Simon,
I like your idea, because if you don't have enough time to support it,
project will die or be forked. Actually dbus has a good
commits-per-month counter so i don't afraid :). I also believe there
is a lot of people who can do the job (and want to join to dbus team)
with a necessary quality: just share your ideas, vision, the future of
the project, rules. Be the Yoda ;)
But! You're saying only about dbus/dbus-glib although there are python
binding, perl binding, minor stuffs like "Bug 36233 - Upload Python
binding on PyPI". There are ~241 opened bug/feature/... requests -
from minor/stupid to critical/great. Many are very old like the punch
cards. Somebody should do it. This 36233 is very simple, but it's
still open since 2011-04-14. What i want to say i that you need to
open the doors for volunteers who will do this minor job. You have
time for discussion, to
answer on a mail in the list - you can convert your thoughts to
code/work via other people and after that just review the result and
allow them to commit.
In the nowadays DBus is not a just C code, but the bindings to the
popular languages and community work like an uploading packages to
PyPI.
2011/5/17 Simon McVittie <simon.mcvittie at collabora.co.uk>:
> People may have noticed that there's a bit of a backlog of fixed bugs
> awaiting review; unfortunately, it seems all the reviewers are busy on other
> things at the moment.
>
> I propose to make these changes to the review procedure:
>
> * Add David Zeuthen (GDBus maintainer) to the list of qualified reviewers.
> This hopefully shouldn't be controversial; Will Thompson has said he's in
> favour of this addition too.
>
> * Relax the review requirement for branches written by someone who's also a
> reviewer: the D-Bus reviewers listed in HACKING may commit branches they
> wrote themselves, as long as:
>
> - the change does not add or change API, ABI or wire-protocol
>
> - there are no objections from the other reviewers listed in HACKING within
> some reasonable time (1 week?) of the patches being added to Bugzilla
>
> - the committer gets a positive review on Bugzilla from someone they
> consider qualified to review that change (not necessarily someone who's
> a dbus committer yet: for instance, Cosimo Alfarano is working on D-Bus
> and related packages with me at the moment, and I'd like to treat his
> reviews as sufficient, at least for things like leak fixes and
> regression-test improvements)
>
> Thoughts?
>
> Regards,
> S
> _______________________________________________
> dbus mailing list
> dbus at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dbus
>
More information about the dbus
mailing list