[PATCH] get rid of --enable-verbose-mode configure option in favor of DBUS_VERBOSE env variable

[Thiago Macieira]

On Thursday, 12 de January de 2012 12.50.45, Simon McVittie wrote:
> The bits with #ifdef VERBOSE are those where omitting the 
> _dbus_verbose() call also allows omission of a function call that isn't 
> an argument to the _dbus_verbose() macro, or an otherwise-unused variable.

A suggestion is to replace the #ifdef with an if to a function or macro that 
evaluates to a constant zero if verbose mode is disabled. For example:

  if (_dbus_is_verbose ()) 
    {
      /* get some needed variables */
      _dbus_verbose("foo", use variable);
    }

-- 
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
   Software Architect - Intel Open Source Technology Center
      PGP/GPG: 0x6EF45358; fingerprint:
      E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/dbus/attachments/20120112/8d836469/attachment.pgp>