[PATCH] fill_user_info: fake user info for 'root' if it can not be found
thiago at kde.org
Mon Feb 25 10:13:32 PST 2013
On segunda-feira, 25 de fevereiro de 2013 18.03.06, Simon McVittie wrote:
> On 25/02/13 15:14, Tom Gundersen wrote:
> > This should make make libdbus a bit more robust against bugs or
> > configuration errors. In particular, it should make it work on an empty
> > /etc or in case nss is broken, misconfigured or simply missing.
> This doesn't seem like something that ought to be wired into every
> sufficiently-low-level library and utility: if it needs to be
> configurable, then it needs to be configurable, and if it doesn't,
> shouldn't libc do this for you?
If NSS is misconfigured or missing or broken, isn't the system broken? No user
will be able to log in, probably not even root. You'll need to start that
system in recovery mode to fix it, in which case you probably don't need D-Bus.
What's more, I'd rather not carry this code inside the daemon and the library
if it's only ever going to be useful for already-otherwise-broken systems or a
handful of weird installations with no /etc. I'd accept the patch only if it's
#ifdef'ed out by a configure-time option.
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
Software Architect - Intel Open Source Technology Center
PGP/GPG: 0x6EF45358; fingerprint:
E067 918B B660 DBD1 105C 966C 33F5 F005 6EF4 5358
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 190 bytes
Desc: This is a digitally signed message part.
More information about the dbus