[PATCH] fill_user_info: fake user info for 'root' if it can not be found

Simon McVittie simon.mcvittie at collabora.co.uk
Mon Feb 25 11:08:25 PST 2013

On 25/02/13 18:58, Tom Gundersen wrote:
>> D-Bus is C89: no C++-style comments, please.
> Ok. If I resubmit should I also fix the comments ~10 lines above?

Only if your patch changes that line anyway; but I'd also accept
separate patches that replace // comments with /* */ ones and do nothing
else (open a bug, priority=lowest).

> I wanted to use something like _dbus_info, but
> couldn't find it. Do you have a function for low-priority logging?

_dbus_verbose(), I suppose (which doesn't usually do anything in
distributions' libdbus, but it's possible to do a debug build where it
actually matters).

Because libdbus doesn't depend on something with a logging framework
(e.g. GLib), our only logging interface is to write to stderr (and
possibly abort(), if it's serious enough). If it's not important enough
to spam stderr, then it's not important enough to mention at all.


More information about the dbus mailing list