[PATCH] Do not build test binaries at 'make all' stage

Simon McVittie simon.mcvittie at collabora.co.uk
Thu May 30 06:23:45 PDT 2013


On 30/05/13 14:02, Chengwei Yang wrote:
> Use check_ instead of noinst_ to avoid build test binaries at 'make all'
> stage, and these binaries then built at 'make check' stage.
> 
> Since not every one will 'make check', so it will save several seconds
> for them.

This is done deliberately, to stop the test binaries ceasing to compile
at all (although ideally, all developers would run "make check" anyway).
Did you see this comment?

>  ## we use noinst_PROGRAMS not check_PROGRAMS for TESTS so that we
>  ## build even when not doing "make check"

We have plenty of CPU time and not enough maintainer time; I would
prefer to limit the number of conditional things.

    S



More information about the dbus mailing list