Starting the kdbus discussions
Greg Kroah-Hartman
gregkh at linuxfoundation.org
Tue Jan 7 17:30:32 PST 2014
On Tue, Jan 07, 2014 at 03:24:28PM -0600, Tyler Hicks wrote:
> Hi Lennart! I've added Greg to cc since John Johansen and I spoke with
> him about this in a hallway at Plumbers last year.
>
> On 2014-01-02 18:08:42, Lennart Poettering wrote:
> > I am sorry, but to make this very clear: this is explicitly not an
> > option. There will not be a payload parser for kdbus in the kernel, as
> > long as the four developers who are working on it have any say. The
> > entire design is based on the concept that the payload is irrelevant to
> > the kernel, and routing is done only according to the metadata we
> > attach. This is a fundamental design decision of kdbus, and the four of
> > us (Kay, Daniel, Greg and I) will refuse this.
>
> I agree that parsing the payload in the kernel is not something that we
> should do. However, I do think that there are some important metadata
> fields hidden away in the opaque sd_bus_message that should be exposed
> to the kernel by way of moving them to the kdbus_msg.
So, you want to parse the payload :)
> I'm proposing that the following fields be moved to the kdbus_msg:
>
> - message type
> - path
> - interface
> - member
> - destination
> - sender
>
> (Note that the destination string is already being tacked onto the
> kdbus_msg, as a kdbus_item, when a well-known name is used for the
> destination.)
What happens when we come up with a different payload type? The kernel
doesn't care about the payload, so please, don't make it parse it, as
there's nothing there that it could even do anything with.
If you want to create a security model that does deal with the specifics
of the payload being sent through kdbus, then put it in the library that
does the talking to the kdbus interface in userspace, like you do today.
Don't make the kernel do the work just because you find changing the
kernel easier than userspace projects, that's lame.
sorry,
greg k-h
More information about the dbus
mailing list