W32 testsuite results - should i be worried?
thiago at kde.org
Thu Mar 6 09:16:29 PST 2014
Em qui 06 mar 2014, às 12:04:36, Simon McVittie escreveu:
> > - return InterlockedIncrement (&atomic->value) - 1; + return
> > __sync_add_and_fetch(&atomic->value, 1)-1;
> We can't accept this patch (at least, not as-is) because it will break
> compilation with CMake + MSVC, which is also a configuration that the
> maintainer of D-Bus on Windows supports. Are InterlockedIncrement()
> and similar bits of Win32 API not available on your platform?
Known issue with MinGW-w64. We used to consider InterlockedIncrement as Win32
API, but we now have to treat it as an MSVC intrinsic.
The code needs #ifdef _MSC_VER before using those functions.
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
Software Architect - Intel Open Source Technology Center
PGP/GPG: 0x6EF45358; fingerprint:
E067 918B B660 DBD1 105C 966C 33F5 F005 6EF4 5358
More information about the dbus