Fix for test-bus unit test on Windows while running the check_segfault_no_auto_start test

[Simon McVittie]

On 26/04/16 01:16, Yiyang Fei wrote:
> The test-bus unit test on Windows systems fails during the
> check_segfault_no_auto_start test.  The output of the error is as follows:
...
> check_segfault_service_no_auto_start:3043 received message interface
> "(unset)" member "(unset)" error name
> "org.freedesktop.DBus.Error.TimedOut" on 000001E176DAE0E0, expecting not
> this error
...
> Since test-segfault.exe application never claims the requested service,
> it makes sense that DBUS_ERROR_TIMED_OUT is returned.

No, this is not what is expected. We should be able to detect that the
activated subprocess has failed (exited abnormally or with exit status
not 0), and report that, immediately; we should not have to wait for an
arbitrary timeout.

I assume you also see a noticeable (multiple seconds) delay before the
message "Failed to activate service
'org.freedesktop.DBus.TestSuiteSegfaultService': timed out"?

This works on Unix, and this is the first I've heard about it failing on
Windows. (Ralf, presumably this test works OK for you?)

Please open a bug in
<https://bugs.freedesktop.org/enter_bug.cgi?product=dbus&component=core>. That's
also the way to ask for a patch to be applied, but in this case I don't
think your proposed patch is the correct change.

Thanks,
    S
-- 
Simon McVittie
Collabora Ltd. <http://www.collabora.com/>