[PATCH 6/7] Protect 'orig_len' in |recover_unused_bytes| by DBUS_ENABLE_VERBOSE_MODE
Simon McVittie
simon.mcvittie at collabora.co.uk
Wed Aug 10 10:35:21 UTC 2016
On 09/08/16 20:18, Thomas Zimmermann wrote:
> +#ifdef DBUS_ENABLE_VERBOSE_MODE
> int orig_len;
> +#endif
> dbus_bool_t succeeded;
>
> _dbus_message_loader_get_buffer (transport->loader,
> &buffer);
>
> +#ifdef DBUS_ENABLE_VERBOSE_MODE
> orig_len = _dbus_string_get_length (buffer);
> +#endif
This is the sort of thing that makes me wonder whether we should just be
disabling the compiler warnings for unused(-but-set) variables when
verbose mode is not enabled... but I think it's OK for master.
--
Simon McVittie
Collabora Ltd. <http://www.collabora.com/>
More information about the dbus
mailing list