[PATCH 7/7] auth: Remove 'WaitingForOK' from client

Simon McVittie simon.mcvittie at collabora.co.uk
Wed Aug 10 10:37:50 UTC 2016


On 09/08/16 20:18, Thomas Zimmermann wrote:
> This patch removes the code for the client's 'WaitingForOK' state, which
> is currently unused. A future patch set should probably implement a more
> strict validation of the protocol states.

If this entire state is unused, this could be indicative of a more
serious problem. Is the state something that should be used but is not,
or is the state meaningless?

The compiler is doing its job here: it is warning about something that
could be a problem. I would prefer not to silence the warning without
first considering whether the problem has been resolved.

-- 
Simon McVittie
Collabora Ltd. <http://www.collabora.com/>



More information about the dbus mailing list