DeviceKit-power future plans

[Richard Hughes]

On Wed, 2008-08-13 at 11:58 -0400, David Zeuthen wrote:
> I finally had some time to look at it. It looks pretty good, thanks for
> hacking on this!

No problem.

>  - The output "data" parameter of Device.GetStatistics() of type
>    "a(uds)" is not documented.
>    - see e.g. http://hal.freedesktop.org/docs/DeviceKit-disks/Device.html#Device.DriveSmartGetHistoricalData

Done.

>  - The Suspend() method on HAL takes a parameter on how long to sleep;
>    AFAIK no one uses this mostly because the wakeup code in Linux sucks.
>    The one on DeviceKit-power doesn't. Should it?

I'm not sure. Maybe another method SetWakeUp time might be better, as
then we can just return with NotSupported if the system can't do it.
Plus then we support wake up from hibernation and shutdown for free.

>  - The udev rules should probably use DKP_ID_BATTERY instead of
>    ID_BATTERY. Just to be nice and not pollute the main name space.

Done. Should all the properties be DPK prefixed? For instance:

SYSFS{idVendor}=="046d", SYSFS{idProduct}=="c508",
ENV{ID_PRODUCT}="Cordless Optical TrackMan",
ENV{DKP_ID_BATTERY_TYPE}="mouse", ENV{ID_CSR_HAS_SMS}="1"

>  - What's up with the libdevkit-power? Is this a C wrapper for the D-Bus
>    service? I think we want to export this... just use proper and nice
>    D-Bus bindings instead.

Well, it's mainly because dbus-glib sucks as a binding. Originally the
library was static as was just used internally, but I made it shared so
that I could reuse giant chunks of it in the modified
gnome-power-manager.

>    - and if do want this
>      - should be licensed more liberally (MIT instead of GPL)
>      - consistency!

Right, I'm pretty bad at licences. I've go no problem with MIT, just all
your original source files were GPLv2+

>        - .pc file should be called devkit-power
>          - not devicekit-power

Fixed.

>        - name of the .so file should be libdevkit-power
>          - not libdkp-power

It is, it's just the source file with the funny name.

>        - headers should be in /usr/include/DeviceKit/devkit-power
>          - not /usr/include/DeviceKit-power/dkp-gobject

Fixed.

> I don't see why DeviceKit-power should be involved with dealing with
> quirks - I think we should just punt the quirks to the pm-utils project,
> e.g. make sure that project delivers the right quirks if the system
> needs it (and I think pm-utils should just use udev rules but that's up
> to the pm-utils maintainers). 

udev rules on what device?

> >  * bloating the public D-Bus interfaces
> 
> Yeah, I'm concerned about that too. Doesn't look to bad so far!

Thanks!

Richard.