changing the enum type
david at fubar.dk
Mon Mar 2 08:20:11 PST 2009
On Mon, 2009-03-02 at 16:10 +0000, Richard Hughes wrote:
> On Mon, 2009-03-02 at 10:56 -0500, David Zeuthen wrote:
> > On Mon, 2009-03-02 at 15:49 +0000, Richard Hughes wrote:
> > > On Fri, 2009-02-27 at 11:03 -0500, David Zeuthen wrote:
> > > > On Fri, 2009-02-27 at 15:25 +0000, Richard Hughes wrote:
> > > > > Right, but using EggDBus the enums would be uint types,
> > > > We'd probably want to change something else but that's fine, we've never
> > > > promised DeviceKit-power was ABI stable (btw, time you do a release
> > > > please explicitly state it in the NEWS file).
> > >
> > > Right, but it is API stable. I'm using it in gnome-power-manager and
> > > it's going to be used in the xfce power manager too. I've also started
> > > porting other applications to use the interfaces rather than HAL.
> > I _very strongly_ disagree we want to mark this as stable API. It's just
> > too early, especially when we are still committing API that turn out not
> > to work well
> Sure, I and you know the API is unstable. But Joe Bloggs doesn't know
> that, and starts to build an application around it. I'm not explicitly
> marking it stable, I'm just pointing out that when we release this,
> people start using it, and expect it to keep working. It's not like
> we're shipping a shared library with headers that have a
> I_KNOW_THIS_IS_UNSTABLE define.
Right, that's why we need to mark it elsewhere. Or bring out bigger guns
like adding .Unstable to interface, object path service names. Or
require the the caller invokes a D-Bus method IKnowThisIsUnstable(). But
I think just mentioning it in NEWS is good enough.
> For the moment, I'll do as you suggest and mark it as unstable in the
> NEWS file next time I do a release.
More information about the devkit-devel