[PATCH] udisks: escape backslash for label string
Martin Pitt
martin.pitt at ubuntu.com
Sat Nov 6 10:06:04 PDT 2010
Hello Jiro,
Jiro SEKIBA [2010-10-15 13:48 +0900]:
>
> validate_and_escape_label will only escapes '"'.
> However, string '\"' will be escaped to '\\"' which leads unmatched
> double quote for shell string in result.
>
> This adds escaping '\' in validate_and_escape_label to avoid the problem.
Thanks for this. I committed a check to the test suite which
reproduces this problem, and I confirm that this fixes it for most
file systems. It still falls over badly for VFAT (which doesn't
support " in labels at all, and thus just interactively hangs around
asking what to do), I'll care for that next.
I pushed your patch.
Martin
--
Martin Pitt | http://www.piware.de
Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.freedesktop.org/archives/devkit-devel/attachments/20101106/22a7666c/attachment.pgp>
More information about the devkit-devel
mailing list