[PATCH] more fine-grained iDevice support in media-player-info

[Christophe Fergeau]

2011/6/12 Tom Gundersen <teg at jklm.no>:
> On Sun, Jun 12, 2011 at 6:08 PM, Christophe Fergeau <cfergeau at gmail.com> wrote:
>> You can look at UDISKS_PRESENTATION_ICON_NAME and
>> UDISKS_PRESENTATION_NAME (set by libgpod udev callout) to get the name
>> of the device as set in iTunes and to get the icon name to use for
>> this device (including its color).
>
> I was indeed looking into doing this from the beginning, and it makes
> sense. The reason I didn't was that I could not get these properties
> set on my device (iPhone 3GS).

Do you know if the udev callout gets run? It should create
automatically iTunes_Control/Device/SysInfoExtended automatically
every time an iPod is plugged in, so you can use that to check if it
runs. I think udevadm has also a way to monitor what it's urnning on
device insertion.

>
> At the moment all we need is to figure out that a certain device
> supports the "ipod" protocol, if I can find this out from some other
> udev properties, then that's fine with me as well.

I'm not sure what you mean by the "ipod" protocol. There are 2 things
to consider, the way to access physical files on the device, which
will be either USB mass storage or afc (for iOS devices), and then the
current "ipod" in media-player-info means that the device has an iPod
music database which needs to be looked at.


>
>> As for your 3rd patch, The AccessProtocol line is wrong for all iOS
>> devices,
>
> Just to make sure I understand; the correct line should simply say "ipod"?
>

No idea actually :) There has been some talks to add some more
information about devices, such as a note that it's an iOS device, but
I don't think it got anywhere for now.

>
>> But I'm really against
>> doing any of this, and would much prefer if m-p-i only said "it's an
>> iPod", and if richer information about these iPods came from libgpod.
>
> An intermediate solution might be to have three files: one for ipods,
> one for ipas and one for iphones. Just so the names are fairly
> reasonable (in case libgpod is not installed to do it properly).

Yes, this makes sense to me if you use regex matching rules and not
USB IDs (ie stuff like USBProduct = "Apple*iPhone*" or whatever the
syntax is)

>
>> With iOS devices handling much more than music/videos/podcasts these
>> days, it may make sense to split the udev callout part of libgpod to a
>> separate module, but for now I'd recommend using this information.
>
> If I can get it to work, I'll do that (should be much simpler from my POV).
>

I assume "I'll do that" == "use this information" ? Or do you want to
do the callout splitting?

Christophe