[PATCH] Adding an argument to Sleeping signal
psusi at cfl.rr.com
Wed Mar 30 08:30:46 PDT 2011
On 3/30/2011 10:15 AM, Richard Hughes wrote:
> Sorry for the delay -- I've been caught up in other GNOME 3 stuff.
> What about the attached patch?
If I am reading this correctly, it looks like upower provides a little
client library to wrap the dbus calls, and your patch is modifying that.
In my patch I just modified the dbus interface and patched g-p-m to use
dbus directly. Why have the shim instead?
> I'm still not sure if it's a sensible thing to change the public DBus
> API at this stage, as other things are using the existing signals
> (notably, NetworkManager). David, Kay, any advice?
Before you said:
> I think breaking API now is okay. You have to define a
> I_KNOW_THE_API_IS_UNSTABLE define to use upower now anyway.
Change your mind? Also it looks like g-p-m pokes nm on suspend/resume.
Does nm also directly monitor the upower signals? If so, that seems to
be a duplication of work.
More information about the devkit-devel