[PATCH upower] Drop 'type' parameter from CancelRequest() signature

Sascha Silbe silbe at activitycentral.com
Tue May 22 12:27:48 PDT 2012

CancelRequest() never worked because the method signature in D-Bus
introspection data didn't match the actual function signature.

Since the 'type' parameter isn't needed by the implementation (cookies
are unique across all requests, not just requests of a certain type),
we drop it from the public API. This makes it easier for clients to
use the API as they only have to remember the cookie, not both cookie
and type. Since it never worked in the first place, there are no
backwards compatibility issues.
 For this patch I'm assuming that others are agreeing with dropping
 the 'type' parameter to CancelRequest(). If the discussion turns out
 otherwise, I'll send a new patch.

 src/org.freedesktop.UPower.QoS.xml |    8 --------
 1 file changed, 8 deletions(-)

diff --git a/src/org.freedesktop.UPower.QoS.xml b/src/org.freedesktop.UPower.QoS.xml
index 8e69f8a..400a0fc 100644
--- a/src/org.freedesktop.UPower.QoS.xml
+++ b/src/org.freedesktop.UPower.QoS.xml
@@ -164,14 +164,6 @@
     <!-- ************************************************************ -->
     <method name="CancelRequest">
       <annotation name="org.freedesktop.DBus.GLib.Async" value=""/>
-      <arg name="type" direction="in" type="s">
-        <doc:doc>
-          <doc:summary>
-            The type of latency to control, <doc:tt>cpu_dma</doc:tt> or
-            <doc:tt>network</doc:tt>.
-          </doc:summary>
-        </doc:doc>
-      </arg>
       <arg name="cookie" direction="in" type="u">

More information about the devkit-devel mailing list