[PATCH 0/9] HID++ (Logitech Unifying) protocol fixes

[Peter Wu]

Hi Julien,

On Thursday 15 August 2013 23:02:51 Julien Danjou wrote:
> On Thu, Aug 15 2013, Julien Danjou wrote:
> > I've tested the whole patch series, and it works fine. It actually seems
> > to fix a small issue I had with the assocaited devices being marked as
> > present while not. The hardware I had under the hand (literally) to test
> > was a M315.
> > 
> > (I can't really judge code, I didn't touch this for a year and it has
> > been majorly rewritten since then).
> 
> Just one little thing Peter, I don't know if that's a side effect, or if
> it was already bugged before (I didn't test 0.9.21 for long), but the
> is-present when set to true, is never set back to false. Aren't they
> still a ping style thing going on to update this field?

Thank you for testing. For these patch series, I have focused on proper usage
of the HID++ protocol, I did not consider properties such as is-present.

I just looked at the is-present property and can confirm that is is still 
"true" even if the device is turned off. Not surprising considering the 
conditions for being "present"; whenever the HID++ version is higher than 
zero, it is considered "present". But after "hidpp: assume HID++ 1.0 for 
unreachable devices", all unreachable devices are considered 1.0 which means 
that the devices are always present after enumeration.

Three new patches (on top of the previous ones) are available at
https://git.lekensteyn.nl/upower/log/?h=hidpp-rework

- hidpp: improve HID++ version detection, fix uninit var
- hidpp: fix properties for unreachable devices
- hidpp: remove unnecessary HID++ 2.0 code

Regards,
Peter
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/devkit-devel/attachments/20130819/d6ba7ed7/attachment.pgp>