K750 fixes in hidpp-rework branch

[Julien Danjou]

On Wed, Aug 28 2013, Peter Wu wrote:

Hi Peter,

> I do not own the K750, so I haven't tested it yet. Thanks for testing btw! It 
> turns out to be a signedness issue *sigh*. The new code (amended) has been 
> pushed, please git pull -f!

Indeed, that fixes everything:

Device: /org/freedesktop/UPower/devices/keyboard_0003o046DoC52Bx0005
  native-path:          /sys/devices/pci0000:00/0000:00:1d.0/usb2/2-1/2-1.1/2-1.1:1.2/0003:046D:C52B.0003/0003:046D:C52B.0005
  vendor:               Logitech, Inc.
  model:                K750
  serial:               5692B2EC
  power supply:         no
  updated:              Thu Aug 29 00:08:17 2013 (31 seconds ago)
  has history:          yes
  has statistics:       no
  keyboard
    present:             yes
    rechargeable:        yes
    state:               charging
    luminosity:          220 lx
    percentage:          46%
  History (charge):
    1377727697	0.000	unknown
  History (rate):
    1377727697	0.000	unknown

[turning off the light, typing in a darker room]

Device: /org/freedesktop/UPower/devices/keyboard_0003o046DoC52Bx0005
  native-path:          /sys/devices/pci0000:00/0000:00:1d.0/usb2/2-1/2-1.1/2-1.1:1.2/0003:046D:C52B.0003/0003:046D:C52B.0005
  vendor:               Logitech, Inc.
  model:                K750
  serial:               5692B2EC
  power supply:         no
  updated:              Thu Aug 29 00:09:18 2013 (0 seconds ago)
  has history:          yes
  has statistics:       no
  keyboard
    present:             yes
    rechargeable:        yes
    state:               discharging
    luminosity:          10 lx
    percentage:          42%
  History (charge):
    1377727758	42.000	discharging
    1377727697	0.000	unknown
  History (rate):
    1377727697	0.000	unknown

Thumbs up!

(this keyboard is too old and the battery is almost dead and has a not
much capacity anymore, i.e. I cannot type for more than an hour without
lighting it, so don't worry about the percentage moving fast)

>> (I'm sorry I didn't have time to dig through the code yet)
>
> For some reason I am at 20 commits now at the hidpp-rework branch. That's a 
> lot of changes. Can somebody review and merge once this issue has been sorted 
> out?

I'd volunteer to review them, but I don't have any commit access to the
repository so it's not like I could so something useful in the end. I'm
not worried yet we didn't have any reply from Richard, considering it's
an holiday season, but I really hope your stuff will get in. They fixes
everything, so kudos.

(Anyway, if things don't move in the upcoming weeks don't hesitate to
ping me so we find a solution to move forward on this.)

-- 
Julien Danjou
# Free Software hacker # independent consultant
# http://julien.danjou.info
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/devkit-devel/attachments/20130829/150f8324/attachment.pgp>