[PATCH][UPower] build: detect udev rules dir

[Tom Gundersen]

On Wed, Mar 20, 2013 at 3:00 PM, Dan Nicholson <dbn.lists at gmail.com> wrote:
>
> On Mar 19, 2013 5:31 AM, "Tom Gundersen" <teg at jklm.no> wrote:
>> -# udev rules go in /lib, not /usr/lib
>> -if test "$prefix" = "/usr" -o "$prefix" = "/usr/local" ; then
>> -  slashlibdir=/lib
>> -else
>> -  slashlibdir=$prefix/lib
>> -fi
>> -AC_SUBST(slashlibdir)
>> +AC_ARG_WITH([udevdir],
>> +            AS_HELP_STRING([--with-udevrulesdir=DIR], [Directory for udev
>> rules]),
>> +            [],
>> +            [with_udevrulesdir=$($PKG_CONFIG --variable=udevdir
>> udev)"/rules.d"])
>> +AC_SUBST([udevrulesdir], [$with_udevrulesdir])
>
> Did you test that the manual setting actually worked? You're passing udevdir
> to AC_ARG_WITH, which will cause autoconf to set with_udevdir. That's not
> what you're using for the actual setting (with_udevrulesdir). I think if you
> change it to [udevrulesdir] it will work.

Ah, you are right. I missed that. Resending.

> Also, it might be a good idea to be defensive and check that pkg-config
> returned anything useful. That's pretty unlikely at that point, though.

I don't think that's really necessary, but if you think so, it might
be best to do that in a separate patch and also make the same change
for the other uses of pkg-config.

-t