Re-unifying udisks and storaged

Martin Pitt martin.pitt at ubuntu.com
Mon Nov 28 21:22:39 UTC 2016


Tomáš Smetana [2016-11-28 14:09 +0100]:
> One thing we miss at the moment is some good communication channel. Github
> does not have mailing lists and since storaged is not a Freedesktop project
> we didn't feel like discussing our stuff here. Perhaps this ML list would be
> a good place to discuss the project's merge.

"devkit-devel" is certainly an odd name in 2016, but as it happens it
probably has the right people subscribed, so as there doesn't seem to
be any parallelism in that regard it seems fine to (continue to) use
this list.

> The tests we actually run are these:
> https://github.com/storaged-project/storaged/tree/master/src/tests/dbus-tests

These look nice, although they seem to require real block devices from
targetcli_config.json? There's surely quite some overlap with
src/tests/integration-test, that seems one good target for cleanup
after the unification.

> >  * At some point I should probably become a storaged project member,
> >    but there is no urgency -- everyone including project members
> >    should always use PRs anyway.
>
> Yes. We have actually decided to let every non-trivial PR unmerged for some
> time so people get chance to add their comments and reviews.

Even for trivial ones it's good to let CI run before landing.
(http://imgur.com/mJT7sDs)

> > So it seems that renaming "storaged" to "udisks" would be the simpler
> > alternative as it would not require changes to external
> > software/packages. If you prefer to keep "storaged", then I think it's
> > better to rename the D-Bus API/library/ABI consistently and port the ~ 30
> > users of it (at least that's how many we have in Debian) to the new
> > names.
>
> I don't know how it works in Debian: this is mostly non-issue on Fedora/RHEL
> so I don't really care as long the result is usable and working from the
> user's perspective.

Usable, yes: Our preliminary Debian packages for storage also use the
Provides: mechanism. However, it's still confusing to have a
"storaged" package and everything inside (binaries, D-Bus method, and
even user-facing CLI) say "udisks" everywhere.

Martin

-- 
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)


More information about the devkit-devel mailing list