[PATCH 2/2] dim: switch to per-branch tag templates

Joonas Lahtinen joonas.lahtinen at linux.intel.com
Tue Dec 12 13:59:18 UTC 2017


On Fri, 2017-12-01 at 10:03 +0100, Daniel Vetter wrote:
> Since we rotate maintainer functions now on a per-release basis, and
> that seems to be a superior model (bettter exchanged and sharing of
> knowledge) per-maintainer templates don't make much sense.
> 
> Instead use per-branch templates. To keep some separation between the
> scripts and the setup I opted to put the templates into the drm-rerere
> branch, where we have nightly.conf already. I've pushed a few examples
> there of what I have in mind.
> 
> Once this has landed I'll send out the patch for drm-rerere with some
> templates to start with.
> 
> Signed-off-by: Daniel Vetter <daniel.vetter at intel.com>

<SNIP>

> @@ -1620,8 +1617,12 @@ function dim_tag_next
>  
>  function tag_summary
>  {
> -	if [ -r $DIM_TEMPLATE_TAG_SUMMARY ]; then
> -		cat $DIM_TEMPLATE_TAG_SUMMARY
> +	local branch tag_template
> +	branch=$1
> +	tag_template=$DIM_PREFIX/drm-rerere/$branch.tag-template

To match with the fixups, may I suggest ${repo}__${branch}? And maybe
to avoid conflict, do we want subfolders? "fixups" + "tag-templates"

Other than that, both are;

Reviewed-by: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation


More information about the dim-tools mailing list