[PATCH 0/2][RFC] Make dim sparse more thorough

Arkadiusz Hiler arkadiusz.hiler at intel.com
Mon Nov 27 14:39:55 UTC 2017


Hey all,

I am planning to add checkpatch and spare check to the CI. Daniel suggested that
we should use dim to limit duplication and make the formats compatible. I am all
up for that.

I am looking forward to polishing the change with your help.


Couple of caveats with current implementation:

  1. Output format is not the greatest, and do need a rework with your help.
     We may want to align it with dim checkpatch output as well.

  2. We are checking out the tree to run the sparse, we need a fallback
     mechanism to get back to the original rev if something goes wrong, any
     ideas on how to do that cleanly?

  3. The change requires addition of a new tool, remap-log, which is usually not
     packaged. I introduced the source file rather crudely here, in the repo.


Example output:

% dim sparse HEAD~~
Commit: drm/i915/execlists: Delay writing to ELSP until HW has processed the previous write
Okay!

Commit: Introduce error
+drivers/gpu/drm/i915/intel_lrc.c:89: Ambiguous (x | !y)

Commit: Remove error
-drivers/gpu/drm/i915/intel_lrc.c:89: Ambiguous (x | !y)


Cheers,
Arek


Arkadiusz Hiler (2):
  remap-log: Add remap-log by Al Viro
  dim: Make dim sparse check each commit in the range-ish

 .gitignore  |   1 +
 Makefile    |   7 +-
 dim         |  40 ++++-
 remap-log.c | 588 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 4 files changed, 631 insertions(+), 5 deletions(-)
 create mode 100644 remap-log.c

-- 
2.13.6



More information about the dim-tools mailing list