[PATCH 3/6] dim: make hard-coded repo URLs local to dim setup

Jani Nikula jani.nikula at intel.com
Fri Oct 6 14:58:23 UTC 2017


dim setup is now the only place that may use them.

Going forward, dim setup could go one step further and dig out
nightly.conf directly from the repo before we've created a worktree
checkout for it.

Signed-off-by: Jani Nikula <jani.nikula at intel.com>
---
 dim | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/dim b/dim
index 26188142c82c..c4a8795fa2e8 100755
--- a/dim
+++ b/dim
@@ -78,11 +78,6 @@ dim=$(basename $0)
 
 today=$(date +%Y-%m-%d)
 
-drm_intel_ssh=ssh://git.freedesktop.org/git/drm-intel
-drm_tip_ssh=ssh://git.freedesktop.org/git/drm-tip
-drm_upstream_git=git://people.freedesktop.org/~airlied/linux
-linux_upstream_git=git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
-
 # Recipients for all dim based pull requests.
 # Add To: lines to the end, Cc: lines in the beginning with -c.
 pull_request_recipients=(
@@ -1865,7 +1860,12 @@ function setup_aux_checkout # name url directory
 
 function dim_setup
 {
-	local remote
+	local remote drm_intel_ssh drm_tip_ssh drm_upstream_git linux_upstream_git
+
+	drm_intel_ssh=ssh://git.freedesktop.org/git/drm-intel
+	drm_tip_ssh=ssh://git.freedesktop.org/git/drm-tip
+	drm_upstream_git=git://people.freedesktop.org/~airlied/linux
+	linux_upstream_git=git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
 
 	if [ ! -d $DIM_PREFIX ]; then
 		echoerr "Directory $DIM_PREFIX doesn't exist."
-- 
2.11.0



More information about the dim-tools mailing list