[PATCH 3/3] dim+qf: fix shellcheck SC2209
Daniel Vetter
daniel.vetter at ffwll.ch
Thu Apr 26 16:30:07 UTC 2018
On Thu, Apr 26, 2018 at 5:47 PM, Daniel Vetter <daniel.vetter at ffwll.ch> wrote:
> Seems like a fairly reasonable thing to check to me, so lets appease
> it.
For reference:
SC2209: Use var=$(command) to assign output (or quote to assign string).
Need to add that to the commit message.
-Daniel
> Signed-off-by: Daniel Vetter <daniel.vetter at intel.com>
> ---
> dim | 6 +++---
> qf | 4 ++--
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/dim b/dim
> index 091dff8518ed..ec51e36b1269 100755
> --- a/dim
> +++ b/dim
> @@ -2216,10 +2216,10 @@ function dim_help
> fi
>
> if hash rst2man 2>/dev/null; then
> - renderer=rst2man
> + renderer="rst2man"
> pager="man -l -"
> else
> - renderer=cat
> + renderer="cat"
> pager=${PAGER:-cat}
> fi
>
> @@ -2254,7 +2254,7 @@ while getopts hdfis opt; do
> case "$opt" in
> d)
> DRY_RUN=--dry-run
> - DRY=echo
> + DRY="echo"
> ;;
> f)
> FORCE=1
> diff --git a/qf b/qf
> index b75e702793d8..bffe9b753fa0 100755
> --- a/qf
> +++ b/qf
> @@ -562,10 +562,10 @@ function qf_help
> fi
>
> if hash rst2man 2>/dev/null; then
> - renderer=rst2man
> + renderer="rst2man"
> pager="man -l -"
> else
> - renderer=cat
> + renderer="cat"
> pager=${PAGER:-cat}
> fi
>
> --
> 2.17.0
>
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
More information about the dim-tools
mailing list