[PATCH 1/2] dim: Workaround Outlook + Patchwork mess.

[Arkadiusz Hiler]

On Thu, Feb 15, 2018 at 11:14:09AM -0800, Rodrigo Vivi wrote:
> Patchwork has a own identity that doesn't respect the author configuration.
> It automatically changes the author to whatever it was last seen on
> the public mailing list.
> 
> In case the response came from an outlook server the author identity
> inside patchwork will get changed to Last, First.
> 
> We have authors that respond emails to public mailing list using
> Intel emails. Even non outlook users can end up having this trouble
> because the Evolution can be setup with EWS, for instance.
> 
> Since we could never fix patchwork for real to respect users
> choice we can workaround it here when applying the patch.

This statement is not true. It's not quite trivial, but definitely possible.

This models needs additional field for email address:
https://github.com/dlespiau/patchwork/blob/master/patchwork/models.py#L308

This part of code needs to save the raw author information using the
newly added field:
https://github.com/dlespiau/patchwork/blob/master/patchwork/bin/parsemail.py#L759
(now it's just updating the name in the association)

Then you need either create a fall-back mechanism in the model so
patches that came in before the change will still use data from the
foreign key to the Person model or create a migration that copies
current authorship information onto the patches.

And update how the mboxes are generated to use the name form the Patch:
https://github.com/dlespiau/patchwork/blob/master/patchwork/views/__init__.py#L218

There's no need of removing the "Person" concept, as it also serves
other purposes (search and ownership management).

Also write a few tests to make sure it works as expected.


Patches are welcome. Repository has CI set up. I have commit right to
this project. I can review and accept pull requests. I can also deploy
the update.


PS. I have it in my backlog, but there are more pressing matters (e.g.
Django 1.8 is being EOLed this water) I am working on :-)

-- 
Cheers,
Arek