[PATCH 2/2] dim: Fix outlook_author variable.

Lucas De Marchi lucas.de.marchi at gmail.com
Wed Feb 28 16:51:22 UTC 2018

On Wed, Feb 28, 2018 at 11:13:12AM +0200, Jani Nikula wrote:
> On Tue, 27 Feb 2018, Rodrigo Vivi <rodrigo.vivi at intel.com> wrote:
> > To be honest current behavior is saving me. It saved me today again when merging DK's patch.
> > I prefer we continue checking only for the name and simply remove the atempt of outlook name.
> > So when merging patch this would block dim and give time to commiter to fix it.

yep, I agree. Thinking on my own case, I'd never want a patch from me
merged with my name reversed. Not that I think there's anything wrong
with it, but it was not how *I* sent the patch.

> From _my_ POV patchwork is still the broken tool here.

I agree. I think there was a desire for a workaround here, but I think
we are all agreeing it makes more harm than help.  I can take a look
next month on what it takes to fix it, although I never played with its
code base.

Lucas De Marchi

More information about the dim-tools mailing list