[PATCH 6/7] qf: Expand qf co

[Daniel Vetter]

On Tue, Jan 23, 2018 at 7:57 PM, Rodrigo Vivi <rodrigo.vivi at intel.com> wrote:
> On Tue, Jan 23, 2018 at 06:52:12PM +0000, Lucas De Marchi wrote:
>> On Mon, Jan 22, 2018 at 12:00:39PM -0800, Rodrigo Vivi wrote:
>> > Let's use the full word.
>> >
>> > Using the alias inside the own script is not good because
>> > it messes up with searches during development.
>> >
>> > Cc: Paulo Zanoni <paulo.r.zanoni at intel.com>
>> > Cc: Michel Thierry <michel.thierry at intel.com>
>> > Cc: James Ausmus <james.ausmus at intel.com>
>> > Cc: Lucas De Marchi <lucas.demarchi at intel.com>
>> > Signed-off-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
>> > ---
>> >  qf | 2 +-
>> >  1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/qf b/qf
>> > index 1e8ae75b4f46..1dd2d265b73f 100755
>> > --- a/qf
>> > +++ b/qf
>> > @@ -419,7 +419,7 @@ function qf_pull
>> >     cd patches
>> >     git pull --ff-only
>> >
>> > -   qf co
>> > +   qf checkout
>>
>> wouldn't it be better to just call the function qf_checkout internally?
>
> indeed... v2 will come...

In dim we make sure there's no recusion with a small exported env
variable + check. But that means all the global variables that are
implicitly passed around need to be reviewed and converted to local
variables. Plus shellcheck'ed. Quite a lot more work.

Just an aside really.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch