[PATCH] dim: replace egrep with grep -E

Daniel Vetter daniel at ffwll.ch
Tue Jan 30 06:43:06 UTC 2018


On Mon, Jan 29, 2018 at 10:39:11AM -0800, Lucas De Marchi wrote:
> Fix shellcheck:
> 
> In dim line 1489:
> echo "$diff_result" | egrep '^[+-]' | egrep -v '^[+-]{3}'
>                       ^-- SC2196: egrep is non-standard and deprecated. Use grep -E instead.
>                                       ^-- SC2196: egrep is non-standard and deprecated. Use grep -E instead.
> 
> Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>

Applied, thanks.
-Daniel

> ---
>  dim | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/dim b/dim
> index a9f7747e9a9d..73936cea4869 100755
> --- a/dim
> +++ b/dim
> @@ -1486,7 +1486,7 @@ function dim_sparse
>  
>          echo "Commit: $(git log -n1 --format='%s' $commit)"
>          if [ -n "$diff_result" ]; then
> -            echo "$diff_result" | egrep '^[+-]' | egrep -v '^[+-]{3}'
> +            echo "$diff_result" | grep -E '^[+-]' | grep -E -v '^[+-]{3}'
>          else
>              echo "Okay!"
>          fi
> -- 
> 2.14.3
> 
> _______________________________________________
> dim-tools mailing list
> dim-tools at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dim-tools

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch


More information about the dim-tools mailing list