[PATCH 2/2] dim: remove redundant warning about BUG

Jani Nikula jani.nikula at intel.com
Fri Mar 2 15:58:00 UTC 2018


checkpatch already covers "WARNING:AVOID_BUG: Avoid crashing the kernel
- try using WARN_ON & recovery code rather than BUG() or BUG_ON()"

Remove the redundant warning in dim.

Signed-off-by: Jani Nikula <jani.nikula at intel.com>
---
 dim | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/dim b/dim
index 35eb16104222..ea9be9ace78c 100755
--- a/dim
+++ b/dim
@@ -1366,11 +1366,6 @@ function checkpatch_commit
 		rv=1
 	fi
 
-	if bug_lines=$($cmd | grep -m 1 -B 1 '^\+.*\WBUG' | grep -c '^[+-].*\WBUG') && [[ "$bug_lines" = "1" ]]; then
-		echoerr "WARNING: New BUG macro added"
-		rv=1
-	fi
-
 	return $rv
 }
 
-- 
2.11.0



More information about the dim-tools mailing list