[PATCH] qf: fix shellcheck warning

Jani Nikula jani.nikula at intel.com
Wed Mar 14 15:22:43 UTC 2018


On Wed, 14 Mar 2018, "Vivi, Rodrigo" <rodrigo.vivi at intel.com> wrote:
>> On Mar 14, 2018, at 2:08 AM, Jani Nikula <jani.nikula at intel.com> wrote:
>> 
>> In qf line 411:
>> git reset --hard $(git rev-parse --abbrev-ref @{u})
>> ^-- SC1083: This { is literal. Check expression (missing ;/\n?) or quote it.
>> ^-- SC1083: This } is literal. Check expression (missing ;/\n?) or quote it.
>> 
>
> Sorry :(
>
>> Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
>> Cc: Lucas De Marchi <lucas.demarchi at intel.com>
>> Fixes: 0db9811183aa ("qf: Make qf_pull -f forcibly clean")
>> Signed-off-by: Jani Nikula <jani.nikula at intel.com>
>
> Acked-by: Rodrigo Vivi <rodrigo.vivi at intel.com>

Thanks, pushed.

BR,
Jani.

>
>> ---
>> qf | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/qf b/qf
>> index 6dcf26970726..d1499ada1951 100755
>> --- a/qf
>> +++ b/qf
>> @@ -408,7 +408,7 @@ function qf_pull
>>    cd patches
>> 
>>    if [[ $FORCE ]]; then
>> -        git reset --hard $(git rev-parse --abbrev-ref @{u})
>> +        git reset --hard $(git rev-parse --abbrev-ref "@{u}")
>>        quiet_pop_all -f
>>    else
>>        git pull --ff-only
>> -- 
>> 2.11.0
>> 
>> _______________________________________________
>> dim-tools mailing list
>> dim-tools at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/dim-tools

-- 
Jani Nikula, Intel Open Source Technology Center


More information about the dim-tools mailing list