[PATCH] dim: Add Documentation to i915 specific paths

Joonas Lahtinen joonas.lahtinen at linux.intel.com
Wed Mar 28 13:55:09 UTC 2018


Quoting Daniel Vetter (2018-03-28 16:33:25)
> On Wed, Mar 28, 2018 at 03:50:19PM +0300, Jani Nikula wrote:
> > On Wed, 28 Mar 2018, Joonas Lahtinen <joonas.lahtinen at linux.intel.com> wrote:
> > > We should not be nagging, we should almost be thanking for adding
> > > Documentation patches for i915 :)
> > >
> > > Signed-off-by: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
> > > Cc: Jani Nikula <jani.nikula at intel.com>
> > 
> > The grep's getting a bit unweildy, but let's save fixing that for a
> > rainy day.
> > 
> > Acked-by: Jani Nikula <jani.nikula at intel.com>
> 
> Could we parse MAINTAINERS instead of duplicating the same list. On this
> rainy day somewhen in the future I mean.

Definitely, then we could even suggest the maintainers to get the Ack
from. I'll merge the patch for now.

Regards, Joonas

> -Daniel
> > 
> > 
> > > ---
> > >  dim | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/dim b/dim
> > > index 9fa6d9cd855b..c30f00c32b31 100755
> > > --- a/dim
> > > +++ b/dim
> > > @@ -1346,7 +1346,7 @@ function check_maintainer
> > >  
> > >          if [ "$branch" = "drm-intel-next-queued" ]; then
> > >             if non_i915_files=$(git diff-tree --no-commit-id --name-only -r $commit | \
> > > -                   grep -v "^\(drivers/gpu/drm/i915/\|include/drm/i915\|include/uapi/drm/i915\)") && [[ -n "$non_i915_files" ]]; then
> > > +                   grep -v "^\(drivers/gpu/drm/i915/\|include/drm/i915\|include/uapi/drm/i915\|Documentation/gpu/i915\)") && [[ -n "$non_i915_files" ]]; then
> > >                     echo -e "The following files are outside of i915 maintenance scope:\n"
> > >                     echo "$non_i915_files"
> > >                     echo -e "\nConfirm you have appropriate Acked-by and Reviewed-by for above files."
> > 
> > -- 
> > Jani Nikula, Intel Open Source Technology Center
> > _______________________________________________
> > dim-tools mailing list
> > dim-tools at lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/dim-tools
> 
> -- 
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch


More information about the dim-tools mailing list