[PATCH 3/5] dim: shut up sed broken pipe noise in apply-pull

[Daniel Vetter]

On Fri, May 4, 2018 at 4:11 PM, Jani Nikula <jani.nikula at linux.intel.com> wrote:
> On Fri, 04 May 2018, Daniel Vetter <daniel.vetter at ffwll.ch> wrote:
>> "head" immediately closes its stdin, which upsets sed. Shut it up.
>
> I don't understand this, care to expand? Can't review stuff I don't
> understand. :p

Our pipeline is sed | head, as soon as head has enough lines it closes
its stdin. sed keeps writing, notes the EPIPE, gets pissed and dumps
some complaints into stderr. Redirecting stderr shuts it up.

That better?
-Daniel

>
> BR,
> Jani.
>
>>
>> Cc: Dave Airlie <airlied at gmail.com>
>> Signed-off-by: Daniel Vetter <daniel.vetter at intel.com>
>> ---
>>  dim | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/dim b/dim
>> index 97b4f8d1531b..010dd2001254 100755
>> --- a/dim
>> +++ b/dim
>> @@ -915,7 +915,7 @@ function dim_apply_pull
>>
>>       cat > $file
>>
>> -     pull_branch=$(sed -e '0,/[gG]it repository at:$/d' $file | head -n 2 | tail -n 1)
>> +     pull_branch=$(sed -e '0,/[gG]it repository at:$/d' $file 2> /dev/null | head -n 2 | tail -n 1)
>>
>>       if [[ -z "$pull_branch" ]] ; then
>>               echoerr "no pull request found"
>
> --
> Jani Nikula, Intel Open Source Technology Center



-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch