[RFC] dim: Add warncheck subcommand

[Arkadiusz Hiler]

On Thu, May 24, 2018 at 03:18:36PM +0300, Jani Nikula wrote:
> On Thu, 24 May 2018, Arkadiusz Hiler <arkadiusz.hiler at intel.com> wrote:
> > What do you mean by 'make check'?
> 
> Just that. Run in it in maintainer-tools branch.

Ah, misread that, I thought there's some in-kernel make check, that does
the same thing as the whole patch and it eluded me.

Just like that:

make check stop for me early, complaining about a lot of errors in
bash_complection and qf.

In bash_completion line 140:
                        COMPREPLY=( $( compgen -W "--rebase" -- $cur ) )
                                    ^-- SC2207: Prefer mapfile or read -a to split command output (or quote to avoid splitting).


In qf line 438:
        conflict_files=$(quilt push -f | grep "saving rejects" | sed -e "s/.*saving rejects to file \(.*\)/\1/")
                                                                                                    ^-- SC1117: Backslash is literal in "\(". Prefer explicit escaping: "\\(".
                                                                                                        ^-- SC1117: Backslash is literal in "\)". Prefer explicit escaping: "\\)".
                                                                                                           ^-- SC1117: Backslash is literal in "\1". Prefer explicit escaping: "\\1".


In qf line 533:
                renderer=cat
                ^-- SC2209: Use var=$(command) to assign output (or quote to assign string).

make: *** [Makefile:51: shellcheck] Error 1
ahiler-desk1 ahiler maintainer-tools maintainer-tools?! % shellcheck -V
ShellCheck - shell script analysis tool
version: 0.4.7
license: GNU General Public License, version 3
website: http://www.shellcheck.net