[PATCH] dim: handle repo URLs ending with forward slash

Daniel Vetter daniel at ffwll.ch
Wed Oct 24 08:12:33 UTC 2018


On Tue, Oct 23, 2018 at 04:33:21PM +0100, Emil Velikov wrote:
> From: Emil Velikov <emil.velikov at collabora.com>
> 
> Seems like some of my existing URLs had a trailing forward slash.
> This confused url_to_remote(), resulting in adding the exact same repo
> again.
> 
> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
> ---
>  dim | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/dim b/dim
> index 93e90a4f96d0..71a681278cbc 100755
> --- a/dim
> +++ b/dim
> @@ -192,7 +192,7 @@ function url_to_remote # url [url ...]
>  	fi
>  
>  	for url; do
> -		remote=$(git remote -v | grep -m 1 "$url (" | cut -f 1)
> +		remote=$(git remote -v | grep -m 1 "$url/* (" | cut -f 1)

? instead of *, or do you have entire piles of trailing slashes? Otherwise
lgtm, makes sense.
-Daniel

>  		if [[ -n "$remote" ]]; then
>  			echo "$remote"
>  			return 0
> -- 
> 2.19.1
> 
> _______________________________________________
> dim-tools mailing list
> dim-tools at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dim-tools

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch


More information about the dim-tools mailing list