[PATCH] dim: be explicit when iterating over $*
Emil Velikov
emil.l.velikov at gmail.com
Wed Oct 24 14:22:48 UTC 2018
From: Emil Velikov <emil.velikov at collabora.com>
Currently one iterates over the function arguments implicitly, via
"for url; do ... done".
Swap to using "for url in $*; do ... done", since it's tad clearer and
obvious for some of us (ahem me).
Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
---
dim | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/dim b/dim
index b4e63ef483a6..03847cbc3aef 100755
--- a/dim
+++ b/dim
@@ -191,7 +191,7 @@ function url_to_remote # url [url ...]
return 1
fi
- for url; do
+ for url in $*; do
remote=$(git remote -v | grep -m 1 "$url/? (" | cut -f 1)
if [[ -n "$remote" ]]; then
echo "$remote"
@@ -232,7 +232,7 @@ function pick_protocol_url # (git|ssh|https|whatever) url [url ...]
shift
# Find the URL that has given protocol
- for url; do
+ for url in $*; do
case $url in
${protocol}://*)
protocol_url=$url
--
2.19.1
More information about the dim-tools
mailing list