[PATCH] gitlab-ci: Use docker images
Daniel Vetter
daniel at ffwll.ch
Wed Oct 31 17:49:09 UTC 2018
On Wed, Oct 31, 2018 at 07:35:13PM +0200, Arkadiusz Hiler wrote:
> On Wed, Oct 31, 2018 at 02:36:12PM +0100, Daniel Vetter wrote:
> > Shrinks the usual pipeline considerably, since we don't first waste a
> > few minutes installing stuff.
> >
> > Signed-off-by: Daniel Vetter <daniel.vetter at intel.com>
> >
> > ---
> > .gitlab-ci.yml | 25 ++++++++++++++++++++++---
> > Dockerfile.fedora | 4 ++++
> > 2 files changed, 26 insertions(+), 3 deletions(-)
> > create mode 100644 Dockerfile.fedora
> >
> > diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> > index 91cb6a20585d..ab68a168b3d8 100644
> > --- a/.gitlab-ci.yml
> > +++ b/.gitlab-ci.yml
> > @@ -1,7 +1,26 @@
> > -image: fedora:latest
> > +image: $CI_REGISTRY/$CI_PROJECT_PATH/dim-fedora:latest
> >
> > -before_script:
> > - - dnf install -y ShellCheck python3-docutils python3-sphinx make
> > +stages:
> > + - containers
> > + - build
> > + - deploy
> > +
> > +container-build:
> > + stage: containers
> > + image: docker:stable
> > + only:
> > + changes:
> > + - Dockerfile.fedora
> > + - .gitlab-ci.yml
>
> In which scenarios do you see value in rebuilding docker images when
> .gitlab-ci.yml changes?
>
> I was considering something similar for IGT but gave up on the idea
> after not being able to came up with sensible, beneficial scenarios.
I think once the docker image flow is fairly stable it's not needed. But
for development and changes I've made use of it a few times now. So I
think it's useful to establish this as a copypasta template.
> Nevertheless,
> Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler at intel.com>
Thanks, Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
More information about the dim-tools
mailing list