[PATCH 05/11] doc: move commit rights criteria to shared doc

Sean Paul sean at poorly.run
Wed Oct 31 19:32:43 UTC 2018


On Thu, Oct 25, 2018 at 06:22:05PM +0300, Jani Nikula wrote:
> No changes in criteria, just rearrangement.
> 
> Signed-off-by: Jani Nikula <jani.nikula at intel.com>

Reviewed-by: Sean Paul <sean at poorly.run>

> ---
>  commit-access.rst | 32 +++++++++++++++++++++++++++++++-
>  drm-misc.rst      | 35 -----------------------------------
>  2 files changed, 31 insertions(+), 36 deletions(-)
> 
> diff --git a/commit-access.rst b/commit-access.rst
> index 54a7402714cd..0bb9ec912535 100644
> --- a/commit-access.rst
> +++ b/commit-access.rst
> @@ -12,7 +12,37 @@ This document outlines the requirements for becoming a committer.
>  drm-misc
>  --------
>  
> -See :ref:`drm-misc`.
> +Commit rights will be granted to anyone who requests them and fulfills the
> +below criteria:
> +
> +- Submitted a few (5-10 as a rule of thumb) non-trivial (not just simple
> +  spelling fixes and whitespace adjustment) patches that have been merged
> +  already.
> +
> +- Are actively participating on discussions about their work (on the mailing
> +  list or IRC). This should not be interpreted as a requirement to review other
> +  peoples patches but just make sure that patch submission isn't one-way
> +  communication. Cross-review is still highly encouraged.
> +
> +- Will be regularly contributing further patches. This includes regular
> +  contributors to other parts of the linux kernel or the open source graphics
> +  stack who only do the oddball rare patch within drm-misc itself.
> +
> +- Agrees to use their commit rights in accordance with the documented merge
> +  criteria, tools, and processes.
> +
> +Apply for an account (and any other account change requests) through
> +
> +https://www.freedesktop.org/wiki/AccountRequests/
> +
> +and please ping the maintainers if your request is stuck.
> +
> +Committers are encouraged to request their commit rights get removed when they
> +no longer contribute to the project. Commit rights will be reinstated when they
> +come back to the project.
> +
> +Maintainers and committers should encourage contributors to request commit
> +rights, especially junior contributors tend to underestimate their skills.
>  
>  drm-intel
>  ---------
> diff --git a/drm-misc.rst b/drm-misc.rst
> index d5f56c3df337..8cd350596597 100644
> --- a/drm-misc.rst
> +++ b/drm-misc.rst
> @@ -175,41 +175,6 @@ Maintainers mostly provide services to keep drm-misc running smoothly:
>  * Take the blame when something goes wrong. Maintainers interface and represent
>    the entire group of committers to the wider kernel community.
>  
> -Commit Rights
> -=============
> -
> -Commit rights will be granted to anyone who requests them and fulfills the
> -below criteria:
> -
> -- Submitted a few (5-10 as a rule of thumb) non-trivial (not just simple
> -  spelling fixes and whitespace adjustment) patches that have been merged
> -  already.
> -
> -- Are actively participating on discussions about their work (on the mailing
> -  list or IRC). This should not be interpreted as a requirement to review other
> -  peoples patches but just make sure that patch submission isn't one-way
> -  communication. Cross-review is still highly encouraged.
> -
> -- Will be regularly contributing further patches. This includes regular
> -  contributors to other parts of the linux kernel or the open source graphics
> -  stack who only do the oddball rare patch within drm-misc itself.
> -
> -- Agrees to use their commit rights in accordance with the documented merge
> -  criteria, tools, and processes.
> -
> -Apply for an account (and any other account change requests) through
> -
> -https://www.freedesktop.org/wiki/AccountRequests/
> -
> -and please ping the maintainers if your request is stuck.
> -
> -Committers are encouraged to request their commit rights get removed when they
> -no longer contribute to the project. Commit rights will be reinstated when they
> -come back to the project.
> -
> -Maintainers and committers should encourage contributors to request commit
> -rights, especially junior contributors tend to underestimate their skills.
> -
>  Code of Conduct
>  ===============
>  
> -- 
> 2.11.0
> 
> _______________________________________________
> dim-tools mailing list
> dim-tools at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dim-tools

-- 
Sean Paul, Software Engineer, Google / Chromium OS


More information about the dim-tools mailing list