[PATCH] dim: Create git_push helper

Daniel Vetter daniel.vetter at ffwll.ch
Wed Aug 7 14:18:09 UTC 2019


On Wed, Aug 7, 2019 at 1:49 PM Arkadiusz Hiler
<arkadiusz.hiler at intel.com> wrote:
>
> On Wed, Aug 07, 2019 at 12:37:21PM +0200, Daniel Vetter wrote:
> > Just a bit of ocd ... One functional change is the switch from $DRY to
> > the $DRY_RUN flag in dim_pull_request. That one didn't have a
> > justification, and the one for the other place in dim_create_branch
> > didn't seem to apply really.
> >
> > Signed-off-by: Daniel Vetter <daniel.vetter at intel.com>
> > ---
> >  dim | 29 +++++++++++++++++------------
> >  1 file changed, 17 insertions(+), 12 deletions(-)
> >
> > diff --git a/dim b/dim
> > index f1b43552cb59..304a4d4ba7d3 100755
> > --- a/dim
> > +++ b/dim
> > @@ -385,6 +385,11 @@ function git_committer_email
> >       echo $committer_email
> >  }
> >
> > +function git_push
> > +{
> > +     git_push "$@"
>
> Looks like we went one substitution too far

On second look the dim rebuilt-tip I ran that looked good indeed
finished itself off with a segmentation fault instead of actually
pushing ... I'll respin.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch


More information about the dim-tools mailing list