[PATCH] dim:- Create and clone 'maintainer-tools' if not present

Daniel Vetter daniel at ffwll.ch
Fri Aug 30 14:52:41 UTC 2019


On Fri, Aug 30, 2019 at 12:04 PM Ayan Halder <Ayan.Halder at arm.com> wrote:
>
> Currently, dim_update_branches fails because $DIM_PREFIX/maintainer-tools is
> not present. It should be created and cloned from ${maintainer_tools_https}
>
> Signed-off-by: Ayan Kumar Halder <ayan.halder at arm.com>

How did you get there without running dim setup first? That should be
done there, and it's not the only thing missing. I thought we even
catch this at startup to make sure people dont get surprises ...
-Daniel

> ---
>  dim | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/dim b/dim
> index 70262b60d513..870ab9d8e371 100755
> --- a/dim
> +++ b/dim
> @@ -2156,6 +2156,11 @@ function dim_update_branches
>                 fi
>         done
>
> +       if [ ! -d $DIM_PREFIX/maintainer-tools ]; then
> +               mkdir -p $DIM_PREFIX/maintainer-tools
> +               git clone $maintainer_tools_https  $DIM_PREFIX/maintainer-tools
> +       fi
> +
>         cd $DIM_PREFIX/maintainer-tools
>         if git_is_current_branch master || git_is_current_branch maintainer-tools; then
>                 echo "Updating maintainer-tools..."
> --
> 2.21.0
>
> IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
> _______________________________________________
> dim-tools mailing list
> dim-tools at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dim-tools



-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch


More information about the dim-tools mailing list