[PATCH 2/2] dim: Catch mailman mangling

[Daniel Vetter]

On Tue, Feb 12, 2019 at 1:21 PM Joonas Lahtinen
<joonas.lahtinen at linux.intel.com> wrote:
>
> Quoting Daniel Vetter (2019-02-12 11:46:35)
> > fd.o had to switch to mangling From: addresses for a lot of domains.
> > Catch them.
>
> Committer e-mail check is bit overcautious, isn't it?

Yeah figured can't hurt either.

> Reviewed-by: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>

Review on patch 1 would be nice too ...
-Daniel

>
> Regards, Joonas
>
> >
> > Cc: Daniel Stone <daniel at fooishbar.org>
> > Signed-off-by: Daniel Vetter <daniel.vetter at intel.com>
> > ---
> >  dim | 7 +++++++
> >  1 file changed, 7 insertions(+)
> >
> > diff --git a/dim b/dim
> > index 9592851cdca8..cb9c0671a501 100755
> > --- a/dim
> > +++ b/dim
> > @@ -858,6 +858,13 @@ function checkpatch_commit_push
> >         # outlook mangles mails into "Last, First"
> >         author_outlook=$(git show -s $sha1 --format="format:%an" | sed -e 's/\([^ ]*\) \(.*\)/\2, \1/')
> >
> > +
> > +       # check for fd.o mailman From: mangling
> > +       if git show -s $sha1 --format="format:%ae %ce"| grep -q '@lists\.freedesktop\.org' ; then
> > +               echoerr "$cite: mailman wrangled email address detected."
> > +               rv=1
> > +       fi
> > +
> >         # check for author sign-off
> >         if ! git show -s $sha1 | grep -qi "Signed-off-by:.*\\($author\\|$author_outlook\\)" ; then
> >                 echoerr "$cite: author Signed-off-by missing."
> > --
> > 2.20.1
> >
> > _______________________________________________
> > dim-tools mailing list
> > dim-tools at lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/dim-tools



-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch