[PATCH] dim: do not run hooks when rebuilding tip

[Jani Nikula]

On Fri, 25 Jan 2019, Daniel Vetter <daniel at ffwll.ch> wrote:
> On Fri, Jan 25, 2019 at 02:27:17AM -0800, Lucas De Marchi wrote:
>> dim rebuild-tip was failing for me and after investigation with Daniel
>> Vetter, the culprit was having a pre-commit git hook enabled. Let's pass
>> --no-verify to avoid the same mistake for other people.
>> 
>> Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>
>
> Reviewed-by: Daniel Vetter <daniel.vetter at ffwll.ch>

Hmm, so how about other places where we run git commit? How about pretty
much every hook git supports and every place where we run git commands
that are affected by hooks?

i.e. where do we draw the line for users shooting themselves in the
foot?


BR,
Jani.


>
>> ---
>>  dim | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/dim b/dim
>> index 00ac1b1340fd..8e1bfa968e4a 100755
>> --- a/dim
>> +++ b/dim
>> @@ -772,7 +772,7 @@ function dim_rebuild_tip
>>  
>>  			# because we filter out fast-forward merges there will
>>  			# always be something to commit
>> -			git commit --no-edit --quiet
>> +			git commit --no-edit --quiet --no-verify
>>  			echo "Done."
>>  		fi
>>  
>> -- 
>> 2.20.0
>> 

-- 
Jani Nikula, Intel Open Source Graphics Center