[PATCH] dim: Only check the commit range on the first parent when doing a PR

Maxime Ripard maxime at cerno.tech
Thu Aug 20 12:55:22 UTC 2020


When creating a PR the current code will try to validate the whole range of
commits between the upstream and the branch we want to create a PR for.

However, if we have merged a tag that isn't in the upstream yet, we will
validate the range between upstream and that tag as well, even though it's
very likely to not follow our rules.

Let's make sure we only consider the first parent, and thus our branch.

Signed-off-by: Maxime Ripard <maxime at cerno.tech>
---
 dim | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dim b/dim
index e4f4d2e95af0..25c77483dca0 100755
--- a/dim
+++ b/dim
@@ -2108,7 +2108,7 @@ function dim_pull_request
 
 		repo="drm-intel"
 	else
-		checkpatch_commit_push_range 1 "$upstream..$branch"
+		checkpatch_commit_push_range 1 "$upstream..$branch" --first-parent
 		tag=$(tag_name "$branch")
 		gitk --first-parent "$branch" ^$upstream &
 		tag_branch $tag $branch
-- 
2.26.2



More information about the dim-tools mailing list