[PATCH] dim: Only check the commit range on the first parent when doing a PR

Maxime Ripard maxime at cerno.tech
Thu Sep 17 08:49:10 UTC 2020


Hi Daniel,

On Sun, Aug 30, 2020 at 08:07:17AM +0200, Daniel Vetter wrote:
> On Tue, Aug 25, 2020 at 3:35 PM Maxime Ripard <maxime at cerno.tech> wrote:
> >
> > When creating a PR the current code will try to validate the whole range of
> > commits between the upstream and the branch we want to create a PR for.
> >
> > However, if we have merged a tag that isn't in the upstream yet, we will
> > validate the range between upstream and that tag as well, even though it's
> > very likely to not follow our rules.
> >
> > Let's make sure we only consider the first parent, and thus our branch.
> >
> > Signed-off-by: Maxime Ripard <maxime at cerno.tech>
> 
> But this misses stuff when you pull in topic branches, which generally
> should follow our rules. So if this has been just because of the
> backmerge I'd leave it as-is, if some topic branch from a non-drm
> maintainer upset things, I guess maybe need to reconsider.

I guess we can :)

The virtio PR I merged earlier this week is in the same situation

Maxime
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dim-tools/attachments/20200917/3df4027c/attachment.sig>


More information about the dim-tools mailing list