Should we accept # comment marks on fixes and parse them out?
Vivi, Rodrigo
rodrigo.vivi at intel.com
Tue Sep 29 19:37:13 UTC 2020
Apparently #x86-32 as comment is breaking dim on the fixes flow.
$ tdim push drm-intel-next-fixes
dim: d6ec212e4a0d ("drm/i915/gem: Avoid implicit vmap for highmem on x86-32"): Subject in fixes line doesn't match referenced commit:
dim: fb8621d3bee8 ("drm/i915: Avoid allocating a vmap arena for a single page") #x86-32
dim: ERROR: issues in commits detected, aborting
Should we parse the comment out?
if yes:
a simple
fixes_subject=$(echo "${BASH_REMATCH[2]}" | cut -d# -f1
didn't work out with current comparison flow..
any suggestion for a clean parse and comparison?
More information about the dim-tools
mailing list