[PATCH] doc: Mention dim cherry-pick command in getting started page

Rodrigo Vivi rodrigo.vivi at intel.com
Thu Jul 7 21:08:00 UTC 2022


On Thu, Jul 07, 2022 at 10:07:12PM +0200, Javier Martinez Canillas wrote:
> Hello Rodrigo,
> 
> Thanks for your feedback.
> 
> On 7/7/22 20:50, Rodrigo Vivi wrote:
> > On Thu, Jul 07, 2022 at 12:06:44PM +0200, Thomas Zimmermann wrote:
> 
> [snip]
> 
> >>> diff --git a/getting-started.rst b/getting-started.rst
> >>> index ea672497982d..44043fb2e5b3 100644
> >>> --- a/getting-started.rst
> >>> +++ b/getting-started.rst
> > 
> > The addition is good, but should we really put this in this getting start section?
> > or improve the dim doc itself:
> > https://drm.pages.freedesktop.org/maintainer-tools/dim.html
> > 
> > or maybe because this is really useful for the drm-misc committers
> > add it to the drm-misc pages like:
> > https://drm.pages.freedesktop.org/maintainer-tools/committer-drm-misc.html
> > 
> 
> This patch was driven by the fact that I made this mistake even when have
> been using dim for some time. A patch landed in -rc5 via drm-misc-fixes,
> and I missed that a follow-up patch was also needed to have a complete fix.
> 
> So I thought that this information should be in a very prominent place and
> probably many developers won't look at the other documentation pages if is
> enough the information that they find in the getting started page.
> 
> I see the content of that page as a dim workflow summary and that's why I
> think that cherry-pick should be part of it (just like you have checkout,
> apply, push, etc). After all, applying from the list and cherry-picking
> are the two operations that most developers are going to do with dim.
> 
> But if the agreement is that this shouldn't be in that page, I can move it
> somewhere else.

I actually don't have strong preferences on the place... With Daniel and Jani
on vacation I will merge this right now and we can always move things later.

Better to have this info there than nowhere. Thanks for the patch!

> 
> -- 
> Best regards,
> 
> Javier Martinez Canillas
> Linux Engineering
> Red Hat
> 


More information about the dim-tools mailing list