[PATCH] dim: shut up git add harder

[Rodrigo Vivi]

On Wed, Mar 29, 2023 at 03:42:43PM +0200, Daniel Vetter wrote:
> On Tue, 28 Mar 2023 at 20:11, Rodrigo Vivi <rodrigo.vivi at intel.com> wrote:
> >
> > On Tue, Mar 28, 2023 at 07:36:44PM +0200, Daniel Vetter wrote:
> > > Apparently my git (v2.40.0) does more warnings and we're not silencing
> > > all the possible ones in the commit_rerere_cache function
> > >
> > > Signed-off-by: Daniel Vetter <daniel.vetter at intel.com>
> > > ---
> > >  dim | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/dim b/dim
> > > index b87b54259f8b..c630d7295568 100755
> > > --- a/dim
> > > +++ b/dim
> > > @@ -667,7 +667,7 @@ function commit_rerere_cache
> > >                       git rm $file &> /dev/null || true
> > >               fi
> > >       done
> > > -     find rr-cache/ -mtime -1 -type f -not -name "thisimage*" -print0 | xargs -0 git add > /dev/null || true
> > > +     find rr-cache/ -mtime -1 -type f -not -name "thisimage*" -print0 | xargs -0 git add &> /dev/null || true
> >
> > nothing we should be concerned with since they are marked as errors?
> >
> > also no possible true error that we would be now masking off?
> 
> We already have the || true to eat any errors, and all other lines
> with git add || true do eat both stdou and stderr (at least in this
> function). So really seems like just an oversight.

oh, indeed.
So, let's move with this then:

Reviewed-by: Rodrigo Vivi <rodrigo.vivi at intel.com>


> -Daniel
> 
> >
> > >       git rm rr-cache/rr-cache &> /dev/null || true
> > >
> > >       commit_message=$(mktemp)
> > > --
> > > 2.40.0
> > >
> 
> 
> 
> -- 
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch