[PATCH dim-tools] dim: Check for maintainer's ack when merging on behalf of another tree
Lukas Wunner
lukas at wunner.de
Sat Jul 5 09:03:28 UTC 2025
On Fri, Mar 01, 2024 at 01:58:25PM +0100, Maxime Ripard wrote:
> We've recently had multiple occurences of people taking patches through
> the drm-misc tree for parts of the kernel that aren't under drm-misc
> maintenance, and without the maintainers Ack.
>
> While merging patches on behalf of someone else is totally something we
> can do, we need to tell the maintainer and make sure he's fine with
> that.
>
> This patch adds some logic to detect if the the range of commits belong
> indeed to the branch we are currently working on, and if not check for
> the maintainer's Acked-by or Signed-off-by.
This was pushed to maintainer-tools yesterday and immediately tripped me
up when trying to push a commit amending MAINTAINERS:
https://lore.kernel.org/r/aGjd01Lyn5reVAEN@wunner.de
That's because...
git show HEAD | \
scripts/get_maintainer.pl --no-git-fallback -m --nol --norolestats
...returns nothing.
I had to cheat by inserting a "return 0" in checkpatch_maintainer().
I think we either need to return 0 if the command returns nothing
(i.e. no known maintainers) or we need a whitelist for certain files.
Thanks,
Lukas
More information about the dim-tools
mailing list